Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashera 0.15.1 #1068

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

SMerrony
Copy link
Contributor

@SMerrony SMerrony commented May 21, 2024

Update to latest release.
Created via alr publish with alr 2.0.1

@SMerrony SMerrony marked this pull request as ready for review May 21, 2024 06:21
@mosteo mosteo added the action needed: fix dependencies Missing dependencies, invalid compiler versions label May 21, 2024
@mosteo
Copy link
Member

mosteo commented May 21, 2024

Similar errors to #1062 ?

@SMerrony
Copy link
Contributor Author

Similar errors to #1062 ?

Indeed - but from my perspective, the problem is within the Gtkada crate, not mine.

@mosteo
Copy link
Member

mosteo commented May 21, 2024

Indeed - but from my perspective, the problem is within the Gtkada crate, not mine.

That's possible, a dependency missing in gtkada itself?

@simonjwright
Copy link
Contributor

simonjwright commented May 22, 2024

I can speak to the macports issue: in libgtk3-external, I should have used the gtk3-devel package, not plain gtk3. Will get right to it.

I wonder what other similar errors we have? I’m not a macports user.

Should we update pkg_config-external to support Centos? (the package would be pkgconfig)

@simonjwright
Copy link
Contributor

There's a tricky problem with libgtk3 on macOS MacPorts.

The trouble is that, for reasons whose force I don't see, the MacPorts maintainers insist that the default backend for gtk3 and glib2 should remain x11, whereas the native macOS backend is quartz. Homebrew has gone over to quartz completely.

You would think we could change libgtk2-external to say macports = ["gtk3", "+quartz"] or something similar, but alr doesn't support that. And, in any case, MacPorts would happily install the +x11 version of glib, regardless of the compatibility with gtk3.

There seems to be one way of countering this problem, and anyone who uses MacPorts and gtkada will have to go this way (if they haven't already): edit the file /opt/local/etc/macports/variants.conf, and uncomment the line

#   -x11 +no_x11 +quartz

As to what we should do about the current crate CI situation, we could

  • not test MacPorts, or
  • make sure to accept crates which fail for this reason, or
  • edit variants.conf as above.

@mosteo
Copy link
Member

mosteo commented May 23, 2024

  • edit variants.conf as above.

Thanks for the assessment, @simonjwright. If users would need to do this anyway, or ensure they use the quartz variant somehow, I think we can adjust our workflow to do the same.

@mosteo
Copy link
Member

mosteo commented May 23, 2024

@SMerrony, when I labeled this as fix dependencies, I don't mean you must take care of fixing whatever problem is happening upstream; rather that you mark unavailable any platform that is not going to work in normal circumstances, or help identify ambiguous situations that we can work out together.

For example, the Arch failure might be a missing C library in base Arch installations that gtkada should make explicit. This could be fixed with a external dependency here, or adding the dependency to our Arch image, depending on what's most likely to be a regular user situation.

@mosteo
Copy link
Member

mosteo commented May 23, 2024

Should we update pkg_config-external to support Centos? (the package would be pkgconfig)

CentOS was missing libgtk3, which I just added, but even so its version is too old (3.22).

@mosteo
Copy link
Member

mosteo commented May 23, 2024

And Arch I'm not sure what's going on, because /usr/include/glib-2.0/glib.h is installed in our Docker image, which is the same location as in Ubuntu.

@mosteo mosteo mentioned this pull request May 23, 2024
@mosteo
Copy link
Member

mosteo commented May 23, 2024

@SMerrony If it's OK with you, we can go ahead and merge, as the trouble with the remaining platforms is in gtkada.

@SMerrony
Copy link
Contributor Author

@SMerrony If it's OK with you, we can go ahead and merge, as the trouble with the remaining platforms is in gtkada.

Fine by me. Sorry for any misunderstandings.

@mosteo mosteo closed this May 27, 2024
@mosteo mosteo reopened this May 27, 2024
@mosteo mosteo merged commit 9f9cca2 into alire-project:stable-1.3.0 May 27, 2024
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action needed: fix dependencies Missing dependencies, invalid compiler versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants